Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add ^9.0.0-0 to R3F peer dependency #2259

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

verekia
Copy link
Contributor

@verekia verekia commented Dec 8, 2024

Fixes #2253

Why

"@react-three/fiber": "9.0.0-rc.1" does not satisfy the ^8 peer dependency declared in Drei.

What

According to semver, ^9.0.0-0 allows pre-releases.
It also allows regular ^9 versions such as 9.2.1, but not other pre-releases, such as 9.2.1-rc.0.

Checklist

  • Ready to be merged

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:32am

Copy link

vercel bot commented Dec 8, 2024

@verekia is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@verekia verekia changed the title chore: add ^9.0.0-0 to R3F peer dependency chore(deps): add ^9.0.0-0 to R3F peer dependency Dec 8, 2024
@abernier
Copy link
Member

abernier commented Dec 8, 2024

@verekia, can you yarn install so it updates yarn.lock ?

@verekia
Copy link
Contributor Author

verekia commented Dec 9, 2024

@abernier Ah, sorry, I am on Yarn Classic, which completely changes the lockfile. Feel free to discard the PR if you want to take care of it 🙏

@abernier
Copy link
Member

abernier commented Dec 9, 2024

you should be able to corepack enable && yarn install like in INSTALL

tell me if it does not work ;)

@verekia
Copy link
Contributor Author

verekia commented Dec 9, 2024

Yeah, it doesn't work, even with corepack enable, it still uses Yarn v1, which messes up the lockfile:

➜  drei:(master) $ corepack enable && yarn install
yarn install v1.22.19
...

@abernier
Copy link
Member

abernier commented Dec 9, 2024

can you try:

$ corepack install --global yarn@stable

and reload your terminal?

@abernier
Copy link
Member

abernier commented Dec 9, 2024

also worth "uninstalling" your previous global yarn binary

Copy link

codesandbox-ci bot commented Dec 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@verekia
Copy link
Contributor Author

verekia commented Dec 9, 2024

Got it working, thank you for your support 🙏

@abernier abernier merged commit 7b0b4b8 into pmndrs:master Dec 9, 2024
4 checks passed
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 9.120.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@CodyJasonBennett
Copy link
Member

CodyJasonBennett commented Jan 4, 2025

This was wrong to do. Drei does not support React 19; nothing on NPM does. In the future, we should bring this up as a team when going over anything with specifity and peer deps. It is a breaking change to correct, and this is creating a myriad of communication errors downstream for users. As a rule of thumb, if it is untested and affects user code, it does not work. We should be incredibly conservative here.

@abernier
Copy link
Member

abernier commented Jan 4, 2025

sorry for the confusion, I initially thought it could have been a good idea to allow users to install drei with r3f rc

but it is not yet compatible with...

^ if i'm now understanding it correctly, this was indeed wrong

@CodyJasonBennett do you want we revert the commit with a fix:?

@borisghidaglia

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add R3F v9 in peerDependencies
4 participants