-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): add ^9.0.0-0 to R3F peer dependency #2259
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@verekia is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
@verekia, can you |
@abernier Ah, sorry, I am on Yarn Classic, which completely changes the lockfile. Feel free to discard the PR if you want to take care of it 🙏 |
you should be able to tell me if it does not work ;) |
Yeah, it doesn't work, even with
|
can you try: $ corepack install --global yarn@stable and reload your terminal? |
also worth "uninstalling" your previous global yarn binary |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Got it working, thank you for your support 🙏 |
🎉 This PR is included in version 9.120.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was wrong to do. Drei does not support React 19; nothing on NPM does. In the future, we should bring this up as a team when going over anything with specifity and peer deps. It is a breaking change to correct, and this is creating a myriad of communication errors downstream for users. As a rule of thumb, if it is untested and affects user code, it does not work. We should be incredibly conservative here. |
sorry for the confusion, I initially thought it could have been a good idea to allow users to install drei with r3f rc but it is not yet compatible with... ^ if i'm now understanding it correctly, this was indeed wrong @CodyJasonBennett do you want we revert the commit with a |
Fixes #2253
Why
"@react-three/fiber": "9.0.0-rc.1"
does not satisfy the^8
peer dependency declared in Drei.What
According to semver,
^9.0.0-0
allows pre-releases.It also allows regular
^9
versions such as9.2.1
, but not other pre-releases, such as9.2.1-rc.0
.Checklist